[ltt-dev] LTTng Statedump Code

Jan Blunck jblunck at suse.de
Wed Sep 17 09:37:16 EDT 2008


I have a question about the current LTTng code. I'm currently reviewing the
code and found things like:

void ltt_dump_sys_call_table(void *call_data)
{
       int i;
       char namebuf[KSYM_NAME_LEN];

       for (i = 0; i < __NR_syscall_max + 1; i++) {
               sprint_symbol(namebuf, (unsigned long)sys_call_table[i]);
               __trace_mark(0, statedump_sys_call_table, call_data,
                       "id %d address %p symbol %s",
                       i, (void*)sys_call_table[i], namebuf);
       }
}
EXPORT_SYMBOL_GPL(ltt_dump_sys_call_table);

This is really confusing. Why do you actually need this? The syscall table
isn't changing that often during runtime. Besides that this is only
implemented for arch/x86.

For what purpose do you need this statedump code in the first place? Doesn't
the /proc interface provide (more than) enough data for you?

Regards,
	Jan

-- 
Jan Blunck <jblunck at suse.de>




More information about the lttng-dev mailing list