<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jun 10, 2014 at 10:52 AM, Antoine Busque <span dir="ltr"><<a href="mailto:antoine.busque@efficios.com" target="_blank">antoine.busque@efficios.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">A typo in an if statement verifying the range in which the current<br>
kernel's version is situated caused build failure for modules on 3.5.0<br>
specifically, by trying to use the new api for block_rq_complete which<br>
has not been backported from the 3.15 branch to the 3.5 branch.<br>
---<br>
instrumentation/events/lttng-module/block.h | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/instrumentation/events/lttng-module/block.h b/instrumentation/events/lttng-module/block.h<br>
index dbe6c6c..ad0a363 100644<br>
--- a/instrumentation/events/lttng-module/block.h<br>
+++ b/instrumentation/events/lttng-module/block.h<br>
@@ -224,7 +224,7 @@ DEFINE_EVENT(block_rq_with_error, block_rq_requeue,<br>
#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,5) \<br>
|| LTTNG_KERNEL_RANGE(3,12,21, 3,13,0) \<br>
|| LTTNG_KERNEL_RANGE(3,10,41, 3,11,0) \<br>
- || LTTNG_KERNEL_RANGE(3,4,91, 3,5,1) \<br>
+ || LTTNG_KERNEL_RANGE(3,4,91, 3,5,0) \<br>
|| LTTNG_KERNEL_RANGE(3,2,58, 3,3,0))<br>
<br>
/**<br>
--<br>
2.0.0</div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">
<br>
</div></div>_______________________________________________<br>
lttng-dev mailing list<br>
<a href="mailto:lttng-dev@lists.lttng.org">lttng-dev@lists.lttng.org</a><br>
<a href="http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev" target="_blank">http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev</a></blockquote><div><br></div>I just realised I forgot to sign off the previous patch,<div>
so I'll resend now. Please excuse the multiple emails,</div><div>I'm still getting the hang of this workflow. </div></div><br></div><div class="gmail_extra">Regards,</div><div class="gmail_extra">Antoine.</div></div>