<div dir="ltr">All right. This is the updated diff for the test case changes. Please have a look.<div><br></div><div><div>diff --git a/test_utils_parse_size_suffix.c.bkup b/test_utils_parse_size_suffix.c</div><div>index 3b9c68c..909dfbc 100644</div>
<div>--- a/test_utils_parse_size_suffix.c.bkup</div><div>+++ b/test_utils_parse_size_suffix.c</div><div>@@ -37,17 +37,48 @@ static struct valid_test_input valid_tests_inputs[] = {</div><div> <span class="" style="white-space:pre"> </span>{ "0", 0 },</div>
<div> <span class="" style="white-space:pre"> </span>{ "1234", 1234 },</div><div> <span class="" style="white-space:pre"> </span>{ "0x400", 1024 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0X400", 1024 },</div>
<div>+<span class="" style="white-space:pre"> </span>{ "0x40a", 1034 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0X40b", 1035 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0x40e", 1038 },</div>
<div>+<span class="" style="white-space:pre"> </span>{ "0X40f", 1039 },</div><div> <span class="" style="white-space:pre"> </span>{ "0300", 192 },</div><div> <span class="" style="white-space:pre"> </span>{ "16k", 16384 },</div>
<div> <span class="" style="white-space:pre"> </span>{ "128K", 131072 },</div><div> <span class="" style="white-space:pre"> </span>{ "0x1234k", 4771840 },</div><div> <span class="" style="white-space:pre"> </span>{ "32M", 33554432 },</div>
<div> <span class="" style="white-space:pre"> </span>{ "1024G", 1099511627776 },</div><div>+<span class="" style="white-space:pre"> </span>{ "00", 0 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0k", 0 },</div>
<div>+<span class="" style="white-space:pre"> </span>{ "0K", 0 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0M", 0 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0G", 0 },</div>
<div>+<span class="" style="white-space:pre"> </span>{ "00k", 0 },</div><div>+<span class="" style="white-space:pre"> </span>{ "00K", 0 },</div><div>+<span class="" style="white-space:pre"> </span>{ "00M", 0 },</div>
<div>+<span class="" style="white-space:pre"> </span>{ "00G", 0 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0x0", 0 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0X0", 0 },</div>
<div>+<span class="" style="white-space:pre"> </span>{ "0x0k", 0 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0X0K", 0 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0x0M", 0 },</div>
<div>+<span class="" style="white-space:pre"> </span>{ "0X0G", 0 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0x40C", 1036 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0X40D", 1037 },</div>
<div>+<span class="" style="white-space:pre"> </span>{ "0X40G", 68719476736 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0300k", 196608 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0300K", 196608 },</div>
<div>+<span class="" style="white-space:pre"> </span>{ "030M", 25165824 },</div><div>+<span class="" style="white-space:pre"> </span>{ "020G", 17179869184 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0xa0k", 163840 },</div>
<div>+<span class="" style="white-space:pre"> </span>{ "0xa0K", 163840 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0XA0M", 167772160 },</div><div>+<span class="" style="white-space:pre"> </span>{ "0xA0G", 171798691840 },</div>
<div> };</div><div> static const int num_valid_tests = sizeof(valid_tests_inputs) / sizeof(valid_tests_inputs[0]);</div><div> </div><div> /* Invalid test cases */</div><div>-static char *invalid_tests_inputs[] = { "", "-1", "k", "4611686018427387904G" };</div>
<div>+static char *invalid_tests_inputs[] = { "", "-1", "k", "08", "09", "4611686018427387904G", "x0", "0xx0", "07kK", "0xk", "0XM", "0xG", "0x0MM", "0X0GG", "0a", "0B"};</div>
<div> static const int num_invalid_tests = sizeof(invalid_tests_inputs) / sizeof(invalid_tests_inputs[0]);</div><div> </div><div> static void test_utils_parse_size_suffix(void)</div></div><div><br></div><div><br></div><div>
Thanks,</div><div>Sandeep.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Apr 9, 2014 at 6:42 AM, Thibault, Daniel <span dir="ltr"><<a href="mailto:Daniel.Thibault@drdc-rddc.gc.ca" target="_blank">Daniel.Thibault@drdc-rddc.gc.ca</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">----------------------------------------------------------------------<br>
Date: Tue, 8 Apr 2014 22:09:36 -0700<br>
From: Sandeep K Chaudhary <<a href="mailto:babbusandy2006@gmail.com">babbusandy2006@gmail.com</a>><br>
To: David Goulet <<a href="mailto:dgoulet@efficios.com">dgoulet@efficios.com</a>><br>
Cc: "<a href="mailto:lttng-dev@lists.lttng.org">lttng-dev@lists.lttng.org</a>" <<a href="mailto:lttng-dev@lists.lttng.org">lttng-dev@lists.lttng.org</a>><br>
<div class=""><br>
> Here is the diff for changes made to the unit test. Please have a look.<br>
</div>----------------------------------------------------------------------<br>
<br>
I would suggest these additional valid and invalid test cases:<br>
<br>
Valid:<br>
<br>
{ "00", 0 },<br>
{ "0k", 0 },<br>
{ "0K", 0 },<br>
{ "0M", 0 },<br>
{ "0G", 0 },<br>
{ "00k", 0 },<br>
{ "00K", 0 },<br>
{ "00M", 0 },<br>
{ "00G", 0 },<br>
{ "0x0", 0 },<br>
{ "0X0", 0 },<br>
{ "0x0k", 0 },<br>
{ "0X0K", 0 },<br>
{ "0x0M", 0 },<br>
{ "0X0G", 0 },<br>
{ "0x40C", 1036 },<br>
{ "0X40D", 1037 },<br>
{ "0X40G", 68719476736 },<br>
{ "0300k", 196608 },<br>
{ "0300K", 196608 },<br>
{ "030M", 25165824 },<br>
{ "020G", 17179869184 },<br>
{ "0xa0k", 163840 },<br>
{ "0xa0K", 163840 },<br>
{ "0XA0M", 167772160 },<br>
{ "0xA0G", 171798691840 },<br>
<br>
Invalid:<br>
<br>
" ", "x0", "0xx0", "07kK", "0xk", "0XM", "0xG", "0x0MM", "0X0GG", "0a", "0B"<br>
<br>
Daniel U. Thibault<br>
Protection des systèmes et contremesures (PSC) | Systems Protection & Countermeasures (SPC)<br>
Cyber sécurité pour les missions essentielles (CME) | Mission Critical Cyber Security (MCCS)<br>
R & D pour la défense Canada - Valcartier (RDDC Valcartier) | Defence R&D Canada - Valcartier (DRDC Valcartier)<br>
2459 route de la Bravoure<br>
Québec QC G3J 1X5<br>
CANADA<br>
Vox : (418) 844-4000 x4245<br>
Fax : (418) 844-4538<br>
NAC : 918V QSDJ <<a href="http://www.travelgis.com/map.asp?addr=918V%20QSDJ" target="_blank">http://www.travelgis.com/map.asp?addr=918V%20QSDJ</a>><br>
Gouvernement du Canada | Government of Canada<br>
<<a href="http://www.valcartier.drdc-rddc.gc.ca/" target="_blank">http://www.valcartier.drdc-rddc.gc.ca/</a>><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Thanks and regards,<br>Sandeep K Chaudhary.
</div>