<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
On 2012-07-31 14:43, David Goulet wrote:<br>
<span style="white-space: pre;">><br>
><br>
> Apart from those minor issues, I have two questions about
this patch. First,<br>
> why is the python module in src/ and not in extras/ ? I
consider src/ to be<br>
> supported and stable code shipped with the installation
and/or in packages.<br>
> Also, the src/ directory is the core code of lttng-tools and
this module is<br>
> more an extra useful tool.<br>
></span><br>
I'm not sure it belongs to extras, since its an actual library that
do something and that is installed on the system.<br>
<br>
If you do not want it in src, we could create a top level python
directory or a binding/python (which allows for other language later
on).<br>
On the other hand, its a binding of the liblttng-ctl, so having the
binding live with the lib directly can be a good idea.<br>
<br>
We should probably do a quick survey of other projects approach.<br>
<br>
<br>
<span style="white-space: pre;">> Second, _IF_ this goes into
src/, please move the tests to the tests/<br>
> directory else we are going to make it self contained in
extras/ which is good<br>
> right now.<br>
></span><br>
yes, good point.<br>
<br>
Yannick<br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.12 (GNU/Linux)<br>
Comment: Using GnuPG with Mozilla - <a class="moz-txt-link-freetext" href="http://enigmail.mozdev.org/">http://enigmail.mozdev.org/</a><br>
<br>
iEYEARECAAYFAlAYL+gACgkQFQrZ7GzHX2rtagCgllef/MlyxLacs1Udta3NB8Y5<br>
WJEAnA5E5zMJ08cLdBMYKjsDhqqIF7BP<br>
=j7S+<br>
-----END PGP SIGNATURE-----<br>
<br>
</body>
</html>