[lttng-dev] [PULL REQUEST babeltrace] Python bindings API refactoring

[Jérémie Galarneau]

On Fri, Nov 22, 2013 at 11:09 PM, Simon Marchi <simon.marchi at polymtl.ca> wrote:
> Also, around line 230, the indentation is inconsistent, so Python
> complains when you import babeltrace.
>
> https://github.com/jgalar/babeltrace/blob/bindings/python/bindings/python/babeltrace.i.in#L230
>
> Btw, thanks for doing this!
>

And thanks for testing! I have addressed both issues and rebased the patches.
Here are the new revisions.

74ea15a Python-bindings: Refactor the Context class
464425e Python-bindings: Refactor the TraceHandle class to use properties
78d714e Python-bindings: Refactor the Event class
e404272 Python-bindings: Move the _scopes array out of the Event class
cb1fcc6 Python-bindings: Refactor the FieldDecl and EventDecl classes
8bb2718 Python-bindings: Move declaration bindings out of the _Definition class
d899d6d Fix: Use the bt_iter_set_pos function to set the begin_pos
5644e6f Fix: Take the iterator's end position into account
da2f697 Fix: bt_ctf_field_generic_validate should return < 0 on error
1400127 Python-bindings: Refactor the CTFWriter API

Regards,
Jérémie

> On 22 November 2013 22:29, Simon Marchi <simon.marchi at polymtl.ca> wrote:
>> I'm getting this error when making in bindings/python:
>>
>> sed "s/BABELTRACE_VERSION_STR/Babeltrace 1.1.1/g" <babeltrace.i.in >babeltrace.i
>> /usr/bin/swig -python -Wall -I. -I../../include babeltrace.i
>> babeltrace.i:367: Error: Syntax error in input(1).
>> make: *** [babeltrace_wrap.c] Error 1
>>
>> Are you missing a little %pythoncode %{ around class ClockType ?
>> https://github.com/jgalar/babeltrace/blob/bindings/python/bindings/python/babeltrace.i.in#L361
>>
>> On 22 November 2013 18:00, Jérémie Galarneau
>> <jeremie.galarneau at efficios.com> wrote:
>>> Hi all,
>>>
>>> I received a number of great comments about the Babeltrace Python API
>>> since my last pull request. These patches, available on my personal
>>> repository, aim at making the API feel more natural to Python
>>> developers by using the appropriate language constructs where
>>> appropriate.
>>>
>>> The three "Fix" patches address bugs that were uncovered in the C
>>> codebase while developing and testing this patch set.
>>>
>>> https://github.com/jgalar/babeltrace.git
>>>
>>> 2be62ad Python-bindings: Refactor the Context class
>>> 32de3db Python-bindings: Refactor the TraceHandle class to use properties
>>> 7740532 Python-bindings: Refactor the Event class
>>> 10d1b96 Python-bindings: Move the _scopes array out of the Event class
>>> 99e8489 Python-bindings: Refactor the FieldDecl and EventDecl classes
>>> 425caab Python-bindings: Move declaration bindings out of the _Definition class
>>> b5e4875 Fix: Use the bt_iter_set_pos function to set the begin_pos
>>> 3f8750e Fix: Take the iterator's end position into account
>>> 35e0cb7 Fix: bt_ctf_field_generic_validate should return < 0 on error
>>> 810922e Python-bindings: Refactor the CTFWriter API
>>>
>>> I think these patches bring us to a point where the bindings/python
>>> branch could be safely merged into master.
>>>
>>> Thanks,
>>> Jérémie
>>>
>>> --
>>> Jérémie Galarneau
>>> EfficiOS Inc.
>>> http://www.efficios.com
>>>
>>> _______________________________________________
>>> lttng-dev mailing list
>>> lttng-dev at lists.lttng.org
>>> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com